Ticket #857 (closed defect: fixed)

Opened 4 years ago

Last modified 10 months ago

Source release process does not include important files

Reported by: mg Assigned to: washort
Priority: low Milestone:
Component: Nevow Severity: normal
Keywords: Cc:
Estimated Completion (YYYY/MM/DD): Branch:
Author:

Description

At least the nevow/athena_private directory is missing; maybe others.

I suspect "python setup.py sdist" was used to build the release but the MANIFEST.in file has not been updated to include all the new files, etc.

The MANIFEST.in needs updating anyway but there are a couple of alternatives for building the source release:

  • Use setup_egg.py. setuptools uses the .svn information to include everything.
  • Create a tar ball from an svn export. That is sure to include everything.

Change History

04/10/06 06:56:53 changed by mg

Quick overview of what's missing (to save a couple of minutes) ... 

matt@jasper:~/tmp/Nevow-0.8.0 $ diff -qr . ../Nevow-0.8.0-export/
Only in ../Nevow-0.8.0-export/examples/pastebin: data
Only in ../Nevow-0.8.0-export/: ez_setup.py
Only in ../Nevow-0.8.0-export/: MANIFEST.in
Only in ../Nevow-0.8.0-export/nevow: athena_private
Only in .: PKG-INFO
Only in ../Nevow-0.8.0-export/: runtests

08/16/06 21:14:38 changed by glyph

  • owner changed from exarkun to washort.
  • priority changed from normal to low.

Reassigning to allen because he is the releasemeister these days.

Also, apparently not ship critical because joule isn't complaining about any missing files.

02/28/08 16:30:41 changed by zooko

This would be fixed by #2527, if setuptools were importable at build time.

03/12/08 20:52:11 changed by zooko

see also allmydata.org "Tahoe" #348 (BuildBot step to run tests from package)

Such a BuildStep could assert that important files are present in the resulting install.

05/20/09 10:31:47 changed by exarkun

  • status changed from new to closed.
  • completion_estimate_date changed.
  • resolution set to fixed.
  • branch changed.
  • branch_author changed.

nevow/athena_private.py is included now, at least. I filed another ticket for some missing css files.

jethro@divmod.org